Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission/dzenana.t web idl #70

Closed
wants to merge 4 commits into from
Closed

Submission/dzenana.t web idl #70

wants to merge 4 commits into from

Conversation

dzenana-trenutak
Copy link
Contributor

Submit WebIDL tests for HTML "sections" and "grouping-content".

The WebIDL tests mean to cover the HTML "sections" and "grouping-content" sections. However, you'll see that there's not just 1 but 5 flavors of each test file, as I'm not sure which approach is the most desired:

  • the "dummies" approach which I saw in existing tests (the "untested" IDL is a bare skeleton) (--> ~50 tests / file)
  • the "full IDL" approach, in which the "untested" IDL contains all the background WebIDL to support the "tested" IDL (--> ~1500 tests / file)
  • the "all tested" approach, in which all the IDL is tested along with the object(s), because, as was recently written on the list, chugging through many / redundant tests is cheap, so "why not". (--> ~2000 tests / file)
  • the "prevent multiple" approach, by which many interfaces can be just tested once within each file. This may be contrary to the "why not" approach, but the API exists, so here it is being used (although separate test files still duplicate tests) (--> ~250 tests / file)
  • the "prevent multiple but test all IDL" approach, which is perhaps an odd compromise but aims to maximize the number of unique tests performed. (--> ~850 tests / file)

I'll be curious to see which one you cherry pick to include in the test suite (if any).

Thank you in advance for any feedback!

@jgraham
Copy link
Contributor

jgraham commented Apr 4, 2013

http://critic.hoppipolla.co.uk/r/47

@zqzhang
Copy link
Contributor

zqzhang commented Dec 5, 2013

As @jgraham pointed out, this duplicates html/dom/interfaces.html; so I would like to close it to avoid review efforts.

@zqzhang zqzhang closed this Dec 5, 2013
jugglinmike pushed a commit to bocoup/wpt that referenced this pull request Apr 11, 2017
@jgraham
Merge pull request web-platform-tests#70 from w3c/jgraham/force_timeout
f448d6f 
Add a force_timeout function to tests.
jgraham pushed a commit that referenced this pull request Apr 13, 2017
@Ms2ger
Merge pull request #70 from w3c/jgraham/path_unquote
5dc7c7c 
Unencode the path when converting to a filesystem path; r=zcorpan
jgraham added a commit that referenced this pull request Apr 13, 2017
@jgraham
Merge pull request #70 from w3c/lint-repo-root
6661d00 
Add a simple test for lint.
jgraham added a commit that referenced this pull request Apr 21, 2017
@jgraham
Merge pull request #70 from AutomatedTester/marionette_imports
e9ec97a 
Update marionette imports to align with upcoming changes to mozilla-cental
gsnedders added a commit to gsnedders/web-platform-tests that referenced this pull request Nov 3, 2017
@gsnedders
Squashed 'resources/webidl2/' changes from 88c5c5b6bb..8a7ff70664
b73adc3 
8a7ff70664 chore(package): bump version number to 8.1.0
f26e320e49 feat: always add rhs property (web-platform-tests#110)
8fc7b2ea19 docs(README): Removed redundant sections
649e457b78 chore(CHANGELOG): regenerate
c1af872481 chore(package): bump version number to 8.0.1
407aaefc9f Remove m postfix from all_ws() (web-platform-tests#108)
8f7c37ea23 chore(package): bump version number to 8.0
6f86663dbc feat: support mixins + includes statements (web-platform-tests#105)
d1f2352275 docs(README): fix typo
0ecc48607c BREAKING CHANGE: drop creator support (web-platform-tests#101)
4f1aab4e77 chore: drop Node 6 support (web-platform-tests#102)
af08834028 style: Normalize some whitespace to pass wpt's lint (web-platform-tests#99)
e938ba5eea chore(package): bump version number to 7.0
cb85ff1a02 BREAKING CHANGE: argument type should be a string
101d9067ae chore(package): bump version number
67af674490 docs(README): extended attribute type
b4013a14cc feat: give extended attributes a type
d15fcb28a9 Yet another innocuous change for tests
dd01a2ba48 Another innocuous change for tests
706d6251d5 Innocuous change to trigger a cvs.w3.org refresh
31be15dd81 chore(package): update jsondiffpatch
ca6c08ccd8 chore(CHANGELOG): regenerate
8ce266fc02 Use ES2015 syntax for tests (web-platform-tests#88)
7ffef282e1 chore(package): bump version number
9d2071443c BREAKING CHANGE: ret enum value as object (web-platform-tests#87)
8360040a9d chore(package): bump version number
fa4b9a3ef1 BREAKING CHANGE: Use ES2015 syntax (web-platform-tests#84)
4252cef22e chore(package): update deps
d6b17d84a1 chore(package): bump version number
174e47ea6d Check duplicated names (web-platform-tests#80)
981743ad2e remove legacycaller (web-platform-tests#79)
99100d174b Add "sequence" property to IDL Type AST definition (web-platform-tests#76)
23fc13f951 chore(CHANGELOG): regenerate
6b53eb357b chore(package): bump version
dbce4340c7 feat: support TypeWithExtendedAttributes on generics (web-platform-tests#75)
c5facac405 chore(CHANGELOG): regenerate
0077262a8f chore(CHANGELOG): regenerate
bbbab23b3d BREAKING CHANGE: remove serializers (closes web-platform-tests#73) (web-platform-tests#74)
5d7a972728 docs(README): add namespaces (web-platform-tests#70)
1ad592c3bb chore(package): bump version
056f0cbaf8 chore(.travis): test for latest LTS/stable node versions (web-platform-tests#69)
c6ef83e72f chore(pacakge): bump version
f5d777c7ab fix extattr whitespace error (web-platform-tests#68)
112e8feb16 chore(package): bump version + update deps
8ec814b9f3 BREAKING CHANGE: deprecate arrays and exceptions (web-platform-tests#67)

git-subtree-dir: resources/webidl2
git-subtree-split: 8a7ff70664ef54fbca77d9bda660865a369e9ce6
AutomatedTester referenced this pull request in AutomatedTester/web-platform-tests Dec 1, 2017
@Tinche @hynek
Speed up Attribute instantiation. (#70)
a7ba512
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Mar 3, 2020
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
b14db07 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
7eb7f6d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
95304f9 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 3, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
7ecac8e 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 4, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
f8f785d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 4, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
2be175d 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 5, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
547d6aa 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
chromium-wpt-export-bot pushed a commit that referenced this pull request Mar 6, 2020
@chromium-wpt-export-bot
[UA client hints] Align implementation with PR#46, #48 & #70
071e0fe 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
Hexcles pushed a commit that referenced this pull request Mar 6, 2020
@Hexcles
[UA client hints] Align implementation with PR#46, #48 & #70
e0be414 
This CL aligns the UA-CH implementation with PR#46[1], #48[2] and
#70[3].

[1] WICG/ua-client-hints#46
[2] WICG/ua-client-hints#48
[3] WICG/ua-client-hints#70

Change-Id: I8221d8a967213180a1aa1d9ef23f17e6f95718b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019369
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Aaron Tagliaboschi <aarontag@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747644}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
html wg-html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzenana-trenutak @jgraham @zqzhang